Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-mobile): Use explorer data when pool info is missing #3856

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Mar 3, 2025

Description / Change(s) / Related issue(s)

Proposal for fallback pool info using explorer data.

Ticket

https://emurgo.atlassian.net/browse/YV-275

@jorbuedo jorbuedo added proposal Feature proposal for triage. Required for non-trivial features. fix labels Mar 3, 2025
@jorbuedo jorbuedo self-assigned this Mar 3, 2025
@stackchain
Copy link
Member

i think is a great idea, @jorbuedo can u update the router to use getComponent if it is using component, to lazy load it, we need to do a mass review on the navigator is loading all screens mostly in one shot

@jorbuedo jorbuedo marked this pull request as ready for review March 4, 2025 10:00
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 22.80%. Comparing base (d2b62f0) to head (931e840).
Report is 1 commits behind head on develop.

❌ Your project status has failed because the head coverage (22.80%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3856      +/-   ##
===========================================
- Coverage    22.82%   22.80%   -0.02%     
===========================================
  Files         1151     1151              
  Lines        21975    21988      +13     
  Branches      3385     3390       +5     
===========================================
  Hits          5015     5015              
- Misses       16815    16828      +13     
  Partials       145      145              
Components Coverage Δ
@yoroi/api 100.00% <ø> (ø)
@yoroi/blockchains 100.00% <ø> (ø)
@yoroi/claim 100.00% <ø> (ø)
@yoroi/common 100.00% <ø> (ø)
@yoroi/dapp-connector 100.00% <ø> (ø)
@yoroi/exchange 100.00% <ø> (ø)
@yoroi/explorers 100.00% <ø> (ø)
@yoroi/identicon 100.00% <ø> (ø)
@yoroi/links 100.00% <ø> (ø)
@yoroi/notifications 100.00% <ø> (ø)
@yoroi/portfolio 100.00% <ø> (ø)
@yoroi/resolver 100.00% <ø> (ø)
@yoroi/setup-wallet 100.00% <ø> (ø)
@yoroi/staking 68.82% <ø> (ø)
@yoroi/swap 100.00% <ø> (ø)
@yoroi/theme 100.00% <ø> (ø)
@yoroi/transfer 100.00% <ø> (ø)
@yoroi/types ∅ <ø> (∅)
@yoroi/wallet-mobile 9.51% <0.00%> (-0.01%) ⬇️

@jorbuedo jorbuedo removed the proposal Feature proposal for triage. Required for non-trivial features. label Mar 4, 2025
@stackchain stackchain merged commit 575857b into develop Mar 4, 2025
20 of 22 checks passed
@stackchain stackchain mentioned this pull request Mar 13, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants